[Bug 407041] Review Request: pcapdiff - Compares packet captures, detects forged, dropped or mangled packets

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pcapdiff - Compares packet captures, detects forged, dropped or mangled packets


https://bugzilla.redhat.com/show_bug.cgi?id=407041


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+

Bug 407041 depends on bug 407031, which changed state.

Bug 407031 Summary: Review Request: pcapy - A Python interface to libpcap
https://bugzilla.redhat.com/show_bug.cgi?id=407031

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |ERRATA



------- Additional Comments From panemade at gmail.com  2007-12-07 03:43 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
2f7f122969c7894a6aff3e72c886f63d  pcapdiff-0.1.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI App.
APPROVED.
         

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.