[Bug 402051] Review Request: libopendaap - Library for connection to iTunes music shares
bugzilla at redhat.com
bugzilla at redhat.com
Sat Dec 8 18:00:49 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: libopendaap - Library for connection to iTunes music shares
https://bugzilla.redhat.com/show_bug.cgi?id=402051
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2007-12-08 13:00 EST -------
For 0.4.0-3:
* License
- This is MIT.
* pkgconfig .pc file / header files.
- First, opendaap.pc says:
-----------------------------------------------------
includedir=/usr/include
Cflags: -I${includedir}
-----------------------------------------------------
However all the header files are under %_includedir/daap
so $ pkg-config --cflags opendaap cannot detect opendaap
header file.
- And /usr/include/daap/portability.h contains
-----------------------------------------------------
36 #include <sys/types.h>
37 #include "config.h"
-----------------------------------------------------
But config.h is not installed
! Note
config.h should not be installed. What is the problem
is that installed header files should not include
(or require) config.h.
* CPP macro
- I guess this usually means "cpp" and this does not relate
to "cp" command.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list