[Bug 398601] Review Request: cairo-clock - Cairo-rendered on-screen clock

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cairo-clock - Cairo-rendered on-screen clock


https://bugzilla.redhat.com/show_bug.cgi?id=398601


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|devel                       |rawhide

karlthered at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: cairo-clock |Review Request: cairo-clock
                   |- Cairo-rendered on-screen  |- Cairo-rendered on-screen
                   |clock                       |clock




------- Additional Comments From karlthered at gmail.com  2007-12-09 09:08 EST -------
Ok, it builds under Mock and it does run. Rpmlint runs OK.
Some issues that should be fixed:
- No pseudonyms. Use your real name and your personal/fedoraproject email.
- vendor should be Fedora.
- %makeinstall macro should not be used.
http://fedoraproject.org/wiki/Packaging/Guidelines#MakeInstall
- Can't download sources. Any input ?
- useless BR: libglade2-devel requires gtk2-devel which requires pango-devel

Please note that + items are OK, - items should be fixed or justified, ~ items
needs further investigation.

* MUST items
+ Respect naming guidelines.
+ License: GPLv2 OK
+ The spec file must be written in American English.
+ The spec file for the package MUST be legible.
- The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
+ Compile on i386 and x86_64 at least.
+ locales are properly handled.
+ Every binary RPM package which stores shared library files (not just symlinks)
in any of the dynamic linker's default paths, must call ldconfig in %post and
%postun. 
+ Not relocatable.
+ A package must own all directories that it creates.
+ A package must not contain any duplicate files in the %files listing.
+ Permissions on files must be set properly. 
+ Each package must have a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
+ Each package must consistently use macros, as described in the macros section
of Packaging Guidelines.
+ The package must contain code, or permissable content. 
+ Large documentation files should go in a -doc subpackage. (The definition of
large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity)
+ If a package includes something as %doc, it must not affect the runtime of the
application.
+ Header files must be in a -devel package.
+ Static libraries must be in a -static package.
+ Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for
directory ownership and usability).
+ If a package contains library files with a suffix (e.g. libfoo.so.1.1), then
library files that end in .so (without suffix) must go in a -devel package.
+ In the vast majority of cases, devel packages must require the base package
using a fully versioned dependency: Requires: %{name} = %{version}-%{release} 
+ Packages must NOT contain any .la libtool archives, these should be removed in
the spec.
+ Packages containing GUI applications must include a %{name}.desktop file, and
that file must be properly installed with desktop-file-install in the %install
section. 
+ Packages must not own files or directories already owned by other packages.  
+ At the beginning of %install, each package MUST run rm -rf %{buildroot} (or
$RPM_BUILD_ROOT). 
+ All filenames in rpm packages must be valid UTF-8.

SHOULD Items:
+ Includes licenses text.
+ The description and summary sections in the package spec file should contain
translations for supported Non-English languages, if available.
+ Builds in mock (i386 & x86_64)
~ Builds on i386 & x86_64 (not tested on PPC)
+ runs without segmentation faults
+ No scriptlets.
+ No subpackages.
+ The placement of pkgconfig(.pc) files depends on their usecase, and this is
usually for development purposes, so should be placed in a -devel pkg. A
reasonable exception is that the main pkg itself is a devel tool not installed
in a user runtime, e.g. gcc or gdb.
+ If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin,
or /usr/sbin consider requiring the package which provides the file instead of
the file itself. Please see File Dependencies in the Guidelines for further
information.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.