[Bug 407581] Review Request: quesoglc - The OpenGL Character Renderer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: quesoglc - The OpenGL Character Renderer


https://bugzilla.redhat.com/show_bug.cgi?id=407581


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-12-09 12:12 EST -------
For 0.6.5-1:

* Possibly missing BuildRequires
  From:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=282900
  http://koji.fedoraproject.org/koji/getfile?taskID=282900&name=build.log
---------------------------------------------------------
   239  checking for FRIBIDI... no
   240  checking for fribidi_log2vis in -lfribidi... no

   249  checking GL/glew.h usability... no
   250  checking GL/glew.h presence... no
   251  checking for GL/glew.h... no
   252  checking for glewContextInit in -lGLEW... no
   253  configure: GLEW will be built and embedded

   258  checking for IceConnectionNumber in -lICE... no
   259  checking for GLUT library... no
   260  configure: WARNING: The GLUT library could not be found : example
programs and some tests will not be built
---------------------------------------------------------
  - fribidi-devel, glew-devel, libICE-devel are all available
    on Fedora.
  - And perhaps the result of line 259 is not what you expect.

* dependency for -devel package
  - %_includedir/GL/glc.h contains
---------------------------------------------------------
    93  #if defined __APPLE__ && defined __MACH__
    94  #include <OpenGL/gl.h>
    95  #else
    96  #include <GL/gl.h>
    97  #endif
---------------------------------------------------------
    This means quesoglc-devel requires mesa-libGL-devel.
    ! Note:
      For (Build)Requires, it is better to use
      "(Build)Requires: libGL-devel" rather than mesa-libGL-devel.

* %check
  - This tarball contains tests/ directory. If some test programs
    can be executed, please create %check section and execute
    some test programs there.

* Encodings
  - The following documents are not encoded in UTF-8. Please
    change to UTF-8.
---------------------------------------------------------
THANKS
---------------------------------------------------------

* Documents
  - Maybe files under docs/ or examples useful as %doc ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.