[Bug 416471] Review Request: xsel -- manipulate the X selection

bugzilla at redhat.com bugzilla at redhat.com
Wed Dec 12 10:20:54 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xsel -- manipulate the X selection


https://bugzilla.redhat.com/show_bug.cgi?id=416471





------- Additional Comments From wolfy at nobugconsulting.ro  2007-12-12 05:20 EST -------
Nothing wrong in using a svn version if this is needed, but if doing so the
script (or at least of a command) needed to recreate the tarball should be
included in the spec. For instance something along
#use "svn co http://svn.kfish.org/xsel/trunk/" to download this branch && mv
trunk xsel-0.9.6  && tar cjf xsel-0.9.6.tar.bz2 xsel-0.9.6" to recreate the
archive.Note that this is the only existing branch, there is no additional
revision information available.
However using xsel-0.9.6 as name for the tarball (as you have done ) is a bit
confusing, since one might believe this is the stable version (which - on the
URL page - has the same name). It would be better in my opinion to name the
tarball xsel-0.9.6-svnsomething, as you have done for the src.rpm itself.
It would also be useful to explain why are you packing the development version
instead of the stable one listed on the project page, especially since the
Changelog and NEWS files are identical in the two versions. And maybe poke
upstream to update the stable version, 6 years for a devel version is long enough...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list