[Bug 323441] Review Request: trousers - The open-source TCG software stack

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: trousers - The open-source TCG software stack


https://bugzilla.redhat.com/show_bug.cgi?id=323441


yoder1 at us.ibm.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW
               Flag|needinfo?(yoder1 at us.ibm.com)|




------- Additional Comments From yoder1 at us.ibm.com  2007-12-12 11:07 EST -------
(In reply to comment #22)
> Well, I just tried to rebuild 3.3.1-2, however it again failed.
> http://koji.fedoraproject.org/koji/taskinfo?taskID=267051
> 
> You have to patch against Makefile.in. Patching against Makefile.am
> does not change anything (unless you call automake or so, however
> please avoid to use autotools when possible).

  Ok, I'll patch Makefile.in...

> * By the way:
> - Not a big problem, however your comments
> ----------------------------------------------------------
> %build
> %configure
> make %{?_smp_mflags}
> 
> #  <- FROM THIS LINE
> # $1 is the number of entries in the RPM database for the package after the
step is
> # executed. So in the post step, if $1 is 1, then this is the first time we've
been
> # installed. If its 2, we're upgrading.
> # <- TO THIS LINE
> %post
> /sbin/ldconfig
> -------------------------------------------------------------
>     is in %build section.

  Do I need to fix this then?

>   - And I usually write in the order of %prep, %build, %install, %clean,
>     %pre, %post, %preun, and %postun (I am only saying my habit).

  Ok, do I need to change it then?

>     By the way, where is %clean section?

  I removed it in response to your comment #13:

> - Please remove unneeded
>   [ "${RPM_BUILD_ROOT}" != "/" ] && [ -d ${RPM_BUILD_ROOT} ] &&

  Should I put it back in the %clean section?

>   - calling ldconfig for -devel package is not needed.

  Yep, I'll take this out.

>   - I recomment to use http://trousers.sourceforge.net/
>     for URL.

  Ok, I'll change this when I update for Makefile.in.

Kent



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.