[Bug 421921] Review Request: argyllcms - ICC compatible color management system

Wed Dec 12 19:57:56 UTC 2007

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request:  argyllcms - ICC compatible color management system

https://bugzilla.redhat.com/show_bug.cgi?id=421921

berrange at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO
               Flag|                            |needinfo?(nicolas.mailhot at la
                   |                            |poste.net)

------- Additional Comments From berrange at redhat.com  2007-12-12 14:57 EST -------
Review based on official guideline list:

MUST: rpmlint must be run on every package.

  $ rpmlint rpm/RPMS/i386/argyllcms-0.70-*
  $ rpmlint argyllcms-0.70-0.1.Beta7.fc9.src.rpm
  argyllcms.src: E: unknown-key GPG#3b29f20d

  - PASS   GPG error is harmless

MUST: The package must be named according to the Package Naming Guidelines.

 - PASS

MUST: The spec file name must match the base package %{name}

 - PASS

MUST: The package must meet the Packaging Guidelines.

 - PASS

MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines.

      cgats/License.txt   - BSD-like
      doc/License.txt     - GPLv3+
      gamut/License.txt   - GPLv3+
      icc/License.txt     - BSD-like
      imdi/License.txt    - GPLv3+
      License.txt         - GPLv3+
      link/License.txt    - GPLv3+
      numlib/License.txt  - GPLv3+
      plot/License.txt    - GPLv3+
      profile/License.txt - GPLv3+
      render/License.txt  - GPLv3+
      rspl/License.txt    - GPLv3+
      scanin/License.txt  - GPLv3+
      spectro/License.txt - GPLv3+
      target/License.txt  - GPLv3+
      tweak/License.txt   - GPLv3+
      xicc/License.txt    - GPLv3+

   Links against libtiff  (libtiff license - BSD-like) and libusb (LGPLv2+)

 - VERIFY - Legal should verify text of the cgats/License.txt & icc/License.txt
 BSD-like files

MUST: The License field in the package spec file must match the actual license.

 - FAIL - Should be  'GPLv3+ and BSD-like' instead of merely 'GPLv3+'

MUST: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.

 - FAIL - %doc should include the cgats/License.txt and icc/License.txt files too

MUST: The spec file must be written in American English.

 - PASS

MUST: The spec file for the package MUST be legible.

 - PASS

MUST: The sources used to build the package must match the upstream source

 - PASS md5sum = cfcfb4d4cd1663ae7b87a68e5f957cee

MUST: The package must successfully compile and build into binary rpms on at
least one supported architecture.

 - PASS built on i686 & x86_64

MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in ExcludeArch.

 - PASS N/A

MUST: All build dependencies must be listed in BuildRequires

 - PASS

MUST: The spec file MUST handle locales properly

 - PASS N/A

MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig in
%post and %postun.

 - PASS N/A

MUST: If the package is designed to be relocatable, the packager must state this
fact in the request for review

 - PASS N/A

MUST: A package must own all directories that it creates.

 - PASS  - recommend changing to use an explicit  %dir though, eg

     %dir %{_datadir}/%{name}
     %{_datadir}/%{name}/*

MUST: A package must not contain any duplicate files in the %files listing.

 - PASS

MUST: Permissions on files must be set properly.

 - PASS

MUST: Each package must have a %clean section

 - PASS

MUST: Each package must consistently use macros

 - PASS

MUST: The package must contain code, or permissable content

 - PASS

MUST: Large documentation files should go in a -doc subpackage

 - PASS

MUST: If a package includes something as %doc, it must not affect the runtime of
the application

 - PASS

MUST: Header files must be in a -devel package.

 - PASS N/A

MUST: Static libraries must be in a -static package.

 - PASS N/A

MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'

 - PASS N/A

MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel package.

 - PASS N/A

MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency

 - PASS N/A

MUST: Packages must NOT contain any .la libtool archives

 - PASS N/A

MUST: Packages containing GUI applications must include a %{name}.desktop file

 - PASS N/A

MUST: Packages must not own files or directories already owned by other packages

 - PASS  For the icclink clash I recommend changing 'argyllcms-icclink' to instead
         be 'icclink-argyll' so it tab-completes under shell

MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}

 - PASS

MUST: All filenames in rpm packages must be valid UTF-8.

 - PASS

SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.

 - PASS N/A

SHOULD: The description and summary sections in the package spec file should
contain translations for supported Non-English languages, if available.

 - PASS N/A

SHOULD: The reviewer should test that the package builds in mock.

 - PASS

SHOULD: The package should compile and build into binary rpms on all supported
architectures.

 - PASS  on x86_64 and i686

SHOULD: The reviewer should test that the package functions as described.

 - FAIL Needs 2 aforementioned buffer overflow patches

SHOULD: If scriptlets are used, those scriptlets must be sane.

 - PASS  N/A

SHOULD: Usually, subpackages other than devel should require the base package
using a fully versioned dependency.

 - PASS N/A

SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this
is usually for development purposes, so should be placed in a -devel pkg.

 - PASS N/A

SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself.

 - PASS N/A

Misc point - the %changelog section contains a number of unusual UTF-8 characters
at the start of each line. Recommend changing them to the standard '-'  prefix for
changelog entries

So in summary

 - Legal needs to review  cgats/License.txt and icc/License.txt
 - License: tag needs fixing
 - Text of the non-GPLv3 License.txt files should be in %doc
 - Fix changelog
 - Rename  arygllcms-icclink to icclink-argyllcms
 - Apply 2 buffer overflow patches

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.