[Bug 225611] Merge Review: bc

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: bc


https://bugzilla.redhat.com/show_bug.cgi?id=225611





------- Additional Comments From pertusus at free.fr  2007-12-14 05:27 EST -------
(In reply to comment #10)
> (In reply to comment #6)
> > (In reply to comment #4)
> > > * Why is there an autotools call?
> > 
> > Because a tarball doesn't contain all needed files. [...]
> 
> The situation was a bit more tricky, actually:
> One of the old patches touched configure.in, so the make called autotools to
> refresh all generated files.  This led to problems, like the complaint about
> missing "depcomp" script, since the tarball was created using Automake 1.4.
> 
> It turns out that the change to configure.in is no longer needed so the patch
> can be removed.  Then the autotools call in spec file can be removed, too.

Even in this case there are better way to do:
* if configure can be patched (which is the case here for the 
  bc-1.06-flex.patch) configure should be patched and autotools not run
* if the changes are more complicated and patching Makefile.in or 
  configure is not possible, the automake/autoconf used to generate the
  tarball (or a compatible one) should be used instead of the current
  autoconf/automake.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.