[Bug 248277] Review Request: mt-daapd - An iTunes-compatible media server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mt-daapd - An iTunes-compatible media server


https://bugzilla.redhat.com/show_bug.cgi?id=248277





------- Additional Comments From sergio.pasra at gmail.com  2007-12-14 20:53 EST -------
* rpmlint says the following in my system:

 - mt-daapd.i386: W: incoherent-version-in-changelog 0.4.2.1-2 0.2.4.1-2.fc7

 - mt-daapd.i386: W: invalid-license GPL
   GPL alone is not valid:
   http://fedoraproject.org/wiki/Packaging/LicensingGuidelines

 - mt-daapd.i386: W: conffile-without-noreplace-flag /etc/mt-daapd.conf 
   mt-daapd.i386: W: conffile-without-noreplace-flag /etc/mt-daapd.playlist
    This can be fixed changing:
    %config %{_sysconfdir}/mt-daapd.conf
    %config %{_sysconfdir}/mt-daapd.playlist
    by
    %config(noreplace) %{_sysconfdir}/mt-daapd.conf
    %config(noreplace) %{_sysconfdir}/mt-daapd.playlist

  - mt-daapd.i386: W: service-default-enabled /etc/rc.d/init.d/mt-daapd:
  
   Only services, which are really required for a vital system, should define  
           runlevels here. Please review the guidelines for initscripts:
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-a6d7a1ed9d77dbb8d4af067378a79b838aebb20a
And there is also a packaging draft:
http://fedoraproject.org/wiki/PackagingDrafts/SysVInitScript

* I would change the Group to Applications/Multimedia, if you don't have a
better idea

* mt-daapd.conf contains passwords in clear text. For security reasons I think
is better to install it with at least 640 permissions


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.