[Bug 405161] Review Request: xvkbd - X virtual Keyboard

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xvkbd - X virtual Keyboard


https://bugzilla.redhat.com/show_bug.cgi?id=405161


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-12-18 12:33 EST -------
Well, for general packaging guidelines you can refer to
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

* Please consider to use %{?dist} tag.
  http://fedoraproject.org/wiki/Packaging/DistTag

Some random comments:

* The license tag "GPL" is not valid for Fedora. Please refer to
  http://fedoraproject.org/wiki/Licensing
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines

* "Requires: Xaw3d libXaw libXtst" are usually not needed
  as rpmbuild checks the dependencies for libraries and adds
  them as Requires, which should automatically pull those rpms.

* Your srpm does not build.
  http://koji.fedoraproject.org/koji/taskinfo?taskID=298953
  At least imake is missing from BuildRequires.

* setup is not quiet (You can check your srpm beforehand by
  using rpmlint [in rpmlint rpm] as $ rpmlint *rpm )

* Please check if your build honors Fedora specific compilation
  flags (please check the section "Compiler flags" of
  "Guidelines" wiki)

* %{_datadir}/X11/app-defaults is already owned by libXt and this
   package should not own this directory.
  ! Note
    When you write
-----------------------------------------------------------
%files
%{_datadir}/X11/app-defaults
-----------------------------------------------------------
    This includes the directory %_datadir/X11/app-defaults itself
    and all files/directories/etc under %_datadir/X11/app-defaults.

* And perhaps installing files under %_libdir/X11/app-defaults is
  not desired.

* Files under %_mandir are automatically tagged as %doc.

* Also please fix %changelog.

! Note:
  Please change the release number of your spec/srpm each time
  when you modify them.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.