[Bug 378951] Review Request: eclipse-photran - Eclipse Fortran Development Tools (Photran) plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-photran - Eclipse Fortran Development Tools (Photran) plugin


https://bugzilla.redhat.com/show_bug.cgi?id=378951





------- Additional Comments From sergio.pasra at gmail.com  2007-12-20 06:32 EST -------
The review:

source files match upstream
package meets naming and versioning guidelines
specfile is properly named, is cleanly written and uses macros consistently OK
dist tag is present
the package must meet the  Packaging Guidelines PROBLEM

I'm not sure that using ExclusiveArch is appropriated here. 
http://fedoraproject.org/wiki/Architectures states that ExclusiveArch
should be avoided and ExcludeArch used instead. 
This is enough to avoid ppc64 compillation:

ExcludeArch: ppc64

In any case, after the packaged is aceepted, you have to open a bug against your 
package, explaining why it doesn't build, and mark it as blocking the
ExcludeArch-ppc64 bug tracker 
https://bugzilla.redhat.com/show_bug.cgi?id=FE-ExcludeArch-ppc64
Then put the bug number in a comment near the ExcludeArch


build root is correct:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
license field matches the actual license. Eclipse Public License
license is open source-compatible.  EPL License text included in package.
(./org.eclipse.photran-feature/epl-v10.html)
latest version is being packaged
BuildRequires are proper
compiler flags are appropriate
%clean is present
package builds in mock ( )
package installs properly
debuginfo package looks complete
rpmlint is silent. WARNING

eclipse-photran.i386: W: one-line-command-in-%post /usr/bin/rebuild-gcj-db
eclipse-photran.i386: W: one-line-command-in-%postun /usr/bin/rebuild-gcj-db

This way is recomended:  
%post -p %{_bindir}/rebuild-gcj-db

%postun -p %{_bindir}/rebuild-gcj-db

final provides and requires are sane
%check is present and all tests pass: Not applicable
no shared libraries are added to the regular linker search paths.
owns the directories it creates.
doesn't own any directories it shouldn't.
no duplicates in %files.
file permissions are appropriate.
no scriptlets present.
code, not content.
documentation is small, so no -docs subpackage is necessary.
%docs are not necessary for the proper functioning of the package.
no headers.
no pkgconfig files.
no libtool .la droppings.
not a GUI app.

So, as a summary:
 * Change ExclusiveArch by ExcludeArch (unless you have a good reason to use the
former)
 * And please use the one line form of %post and %postun


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.