[Bug 416761] Review Request CppAD - A Package for Differentiation of C++ Algorithms

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request CppAD - A Package for Differentiation of C++ Algorithms


https://bugzilla.redhat.com/show_bug.cgi?id=416761





------- Additional Comments From bradbell at seanet.com  2007-12-20 08:57 EST -------
A new version of 
    http://www.seanet.com/~bradbell/cppad/cppad.spec
has been uploaded.

(In reply to comment #2)

> * First of all, would you remove all seemingly-unneeded comments?
>   They make your spec file less easy to read.

Comments have been removed (except for those that are useful to a reviewer).


> * Please consider to use %?_dist tag.
>   http://fedoraproject.org/wiki/Packaging/DistTag

Done.

> 
> * For SourceURL, I recommend to %{version} (also %{name}) tag
>   so that you won't have to modify the SourceURL when version is
>   upgraded.

Done.

> 
> * Why are the Summaries of (fake) main, -devel, -doc are all same?

The summaries and descriptions have been changed to be different for each of the
sub-packages.

> 
> * rm -rf $RPM_BUILD_ROOT is not needed for %prep

As per the instructions on
    http://fedoraproject.org/wiki/Packaging/Guidelines
the rm -rf $RPM_BUILD_ROOT has been moved to the %install section.

> 
> * If some tests are executable, the move them to %check section
>   and remove %{_validation_testing_during_rpmbuild} related description.

I cannot find any documentation or examples for using %check in a spec file.

> 
> * support parallel make if possible.

I think that the new BuildRoot command does this (but I cannot find
documentation for %(%{__id_u} -n)).

> 
> * Please use macros. 
>   http://fedoraproject.org/wiki/Packaging/RPMMacros
>   - For example, /usr must be %_prefix.

Done.

>   - And please use %configure if possible (please check what
>     %configure actually does by
>     $ rpm --eval %configure )

Currently, --with-Documentation is needed on the cppad configure line to get the
documentation. By default, no documentation is installed and people use the web
version (which changes as the trunk of cppad changes). If it is important, this
could be changed.

> 
> * On %install
> if ! make install DESTDIR=$RPM_BUILD_ROOT
> then
> 	echo "Error during make install DESTDIR=$RPM_BUILD_ROOT"
> 	exit 1
> fi
> 
>   "exit 1" is not neede as rpmbuild executes shell script with
>   "set -e" (i.e. if error occurs, the execution of shell script
>    fails)
> 

Checking for program failures has been removed.

> * If this package does not create any debuginfo information, please
>   refer to the section "Useless or incomplete debuginfo packages 
>   due to packaging issues" of
>   http://fedoraproject.org/wiki/Packaging/Debuginfo

A BuildArch: noarch command has been added.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.