[Bug 416761] Review Request CppAD - A Package for Differentiation of C++ Algorithms

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request CppAD - A Package for Differentiation of C++ Algorithms


https://bugzilla.redhat.com/show_bug.cgi?id=416761





------- Additional Comments From bradbell at seanet.com  2007-12-20 12:34 EST -------
A new version of 
    http://www.seanet.com/~bradbell/cppad/cppad.spec
has been uploaded.

(In reply to comment #4)
> Please provide a new srpm also (which release number changed every
> time you modify your spec/srpm) so that we can try to rebuild your
> srpm easily.

Done.
The old rpm has been deleted and the new rpm is
http://www.seanet.com/~bradbell/cppad/cppad-20071208-2.fc7.src.rpm

> 
> (In reply to comment #3)
> > (In reply to comment #2)
> 
> > > * If some tests are executable, the move them to %check section
> > >   and remove %{_validation_testing_during_rpmbuild} related description.
>
The %check command is used for the validation tests and 
%{_validation_testing_during_rpmbuild} has been removed.

As currently implemented, the tests are compiled and run each time an rpmbuild
command is executed. I am not sure if this is the best solution. Perhaps there
is a standard way to skip this using the rpmbuild command line.


> > > * support parallel make if possible.

The %{?_smp_mflags} argument has been added to the make command

> Doesn't "%configure --with-Documentation" work?

Yes it does and the spec file has been changed to use %configure.

> 
> Please use more (please check "RPMMacros" page again).
> /usr/include, /usr/share/doc must be changed.

Done.

> 
> BTW files under %_docdir are automatically marked as %doc.
> 

The %doc command has been removed from infont of 
%{_docdir}/%{name}-%{version}.




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.