[Bug 424841] Review Request: ndisc6 - IPv6 diagnostic tools
bugzilla at redhat.com
bugzilla at redhat.com
Fri Dec 21 05:58:04 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: ndisc6 - IPv6 diagnostic tools
https://bugzilla.redhat.com/show_bug.cgi?id=424841
------- Additional Comments From tibbs at math.uh.edu 2007-12-21 00:58 EST -------
This builds OK in mock on rawhide; rpmlint says the following:
ndisc6.x86_64: E: setuid-binary /usr/bin/rltraceroute6 root 04755
ndisc6.x86_64: E: setuid-binary /usr/bin/rdisc6 root 04755
ndisc6.x86_64: E: setuid-binary /usr/bin/ndisc6 root 04755
ndisc6.x86_64: E: non-standard-executable-perm /usr/bin/rltraceroute6 04755
ndisc6.x86_64: E: non-standard-executable-perm /usr/bin/rdisc6 04755
ndisc6.x86_64: E: non-standard-executable-perm /usr/bin/ndisc6 04755
Setuid binaries are troubling, expecially when the ipv4 counterparts aren't
setuid. Has this code been properly audited? Is it really necessary that
they be setuid?
ndisc6.x86_64: W: symlink-should-be-relative
/usr/share/man/man1/tcpspray6.1.gz /usr/share/man/man1/tcpspray.1.gz
ndisc6.x86_64: W: symlink-should-be-relative
/usr/share/man/man1/name2addr.1.gz /usr/share/man/man1/addr2name.1.gz
ndisc6.x86_64: W: symlink-should-be-relative
/usr/share/man/man8/tracert6.8.gz /usr/share/man/man8/rltraceroute6.8.gz
ndisc6.x86_64: W: symlink-should-be-relative
/usr/share/man/man8/tcptraceroute6.8.gz /usr/share/man/man8/rltraceroute6.8.gz
These should be relative symlinks; they don't really need need any pathname
information at all.
ndisc6.x86_64: W: no-version-in-last-changelog
Changelog entries should be in one of the formats detailed in the Changelogs section of http://fedoraproject.org/wiki/Packaging/Guidelines
ndisc6.x86_64: W: invalid-license GPL2+
I think you mean "GPLv2+"; see http://fedoraproject.org/wiki/Licensing
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list