[Bug 226671] Merge Review: zlib

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: zlib


https://bugzilla.redhat.com/show_bug.cgi?id=226671


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tibbs at math.uh.edu




------- Additional Comments From tibbs at math.uh.edu  2007-12-21 21:03 EST -------
Is anyone actually reviewing this?  fedora-review is set to '?' but I dont' see
anyone assigned to the package.  I'm happy to review this if nobody else is
doing so.

I note a coupe of minor things:

  zlib.x86_64: W: file-not-utf8 /usr/share/doc/zlib-1.2.3/ChangeLog
The ChangeLog file could use a trip through iconv.

The License: tag says BSD, but I would find it odd if the zlib package isn't
under the zlib license.  I believe the License: tag should be "zlib".

I can attach a patch or just fix these in CVS if you like.

There are also several undefined-non-weak-symbol warnings like:

  minizip.x86_64: W: undefined-non-weak-symbol /usr/lib64/libminizip.so.1.0.1 
   inflateEnd
and also for these symbols:
  deflate
  inflateInit2_
  inflate
  crc32
  deflateEnd
  deflateInit2_
  get_crc_table

I think these are bad practice but OK because the minizip.pc file specifies that
packages which use it always link with libz, which will provide the symbols.

I don't have any particular opinion on the minizip executables.  I don't see why
it would be mandatory to ship them if the maintainer doesn't want to, however. 
They're just source in the contrib directory of upstream's tarball, and it's not
really common for that kind of thing to be shipped as part of our packages
unless the maintainer feels some need to include it.

I note that there's a small test suite; generally it's a good thing to call test
suites even if they don't do all that much because they serve as a useful sanity
check.  But I added a %check section and it seems that "make check" doesn't
actually do anything for some reason.  When I call it manually I get some output
ending with "*** zlib test OK ***".  I'm not really sure what the problem is.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.