[Bug 226495] Merge Review: tmpwatch

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: tmpwatch


https://bugzilla.redhat.com/show_bug.cgi?id=226495


adel.gadllah at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adel.gadllah at gmail.com




------- Additional Comments From adel.gadllah at gmail.com  2007-12-22 06:35 EST -------
Ok some comments on this one:
* No URL:

Add an URL tag pointing to the upstream homepage.

* No Source URL:

You have to use the URL to the upstream tarball in the Source tag and not just
the tarball name.
See:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-c17fb8c1ce9be40da720a2b25d1e2a241062038f

NOTE: if it has any homepage... I was unable to find it.

* Parallel make:

Append to make %{?_smp_mflags} in %{build}, unless you have a reason not to do
so (package does not build with parallel make).

See: 

http://fedoraproject.org/wiki/Packaging/Guidelines#head-525c7d76890cb22df33b759c65c35c82bf434d2e



* Macro usage:

Use %{_sysconfdir} instead of /etc



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.