[Bug 426641] Review Request: perl-Algorithm-CheckDigits - Perl extension to generate and test check digits

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Algorithm-CheckDigits - Perl extension to generate and test check digits


https://bugzilla.redhat.com/show_bug.cgi?id=426641





------- Additional Comments From panemade at gmail.com  2007-12-23 12:46 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
c16aacf1770efa50c3db68959f4fae53  Algorithm-CheckDigits-0.48.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
t/checkdigits.....ok
t/ecno............ok
t/iban............ok
t/imei............ok
t/isbn13..........ok
t/pod-coverage....ok
t/pod.............ok
t/upc.............ok
t/valid...........ok
All tests successful.
Files=9, Tests=526,  1 wallclock secs ( 0.43 cusr +  0.06 csys =  0.49 CPU)

+ Package perl-Algorithm-CheckDigits-0.48-1.fc9 ->Provides:
perl(Algorithm::CheckDigits) perl(Algorithm::CheckDigits::M07_001)
perl(Algorithm::CheckDigits::M09_001) perl(Algorithm::CheckDigits::M10_001)
perl(Algorithm::CheckDigits::M10_002) perl(Algorithm::CheckDigits::M10_003)
perl(Algorithm::CheckDigits::M10_004) perl(Algorithm::CheckDigits::M10_005)
perl(Algorithm::CheckDigits::M10_006) perl(Algorithm::CheckDigits::M10_008)
perl(Algorithm::CheckDigits::M10_009) perl(Algorithm::CheckDigits::M10_010)
perl(Algorithm::CheckDigits::M10_011) perl(Algorithm::CheckDigits::M11_001)
perl(Algorithm::CheckDigits::M11_002) perl(Algorithm::CheckDigits::M11_003)
perl(Algorithm::CheckDigits::M11_004) perl(Algorithm::CheckDigits::M11_006)
perl(Algorithm::CheckDigits::M11_007) perl(Algorithm::CheckDigits::M11_008)
perl(Algorithm::CheckDigits::M11_009) perl(Algorithm::CheckDigits::M11_010)
perl(Algorithm::CheckDigits::M11_011) perl(Algorithm::CheckDigits::M11_012)
perl(Algorithm::CheckDigits::M11_013) perl(Algorithm::CheckDigits::M11_015)
perl(Algorithm::CheckDigits::M11_016) perl(Algorithm::CheckDigits::M11_017)
perl(Algorithm::CheckDigits::M16_001) perl(Algorithm::CheckDigits::M23_001)
perl(Algorithm::CheckDigits::M23_002) perl(Algorithm::CheckDigits::M43_001)
perl(Algorithm::CheckDigits::M89_001) perl(Algorithm::CheckDigits::M97_001)
perl(Algorithm::CheckDigits::M97_002) perl(Algorithm::CheckDigits::MBase_001)
perl(Algorithm::CheckDigits::MBase_002) perl(Algorithm::CheckDigits::MBase_003)
perl(Algorithm::CheckDigits::MXX_001) perl(Algorithm::CheckDigits::MXX_002)
perl(Algorithm::CheckDigits::MXX_003) perl(Algorithm::CheckDigits::MXX_004)
perl(Algorithm::CheckDigits::MXX_005) perl(Algorithm::CheckDigits::MXX_006)

Requires: perl >= 0:5.006 perl(:MODULE_COMPAT_5.8.8) perl(Carp)
perl(Data::Dumper) perl(Exporter) perl(integer) perl(strict) perl(vars)
perl(warnings)

APPROVED.
  


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.