[Bug 426064] Review Request: wipe - secure file erasing tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wipe -  secure file erasing tool


https://bugzilla.redhat.com/show_bug.cgi?id=426064





------- Additional Comments From debarshi.ray at gmail.com  2007-12-23 15:23 EST -------
MUST Items: 

OK - rpmlint is clean on SRPM, RPM and installed package
OK - follows Package Naming Guidelines
OK - spec file is named as %{name}.spec

xx - package meets Packaging Guidelines
   + license should be GPL+ since the source code / output/ accompanying
documentation does not state the version:
http://fedoraproject.org/wiki/Licensing#SoftwareLicenses
   + %doc should include BUGS CHANGES GPL examples/wipefd0 examples/wswap.pl
   + use 'install -p' instead of 'install -c' -- -p preserves timestamps, while
-c is ignored
   + consider using '%defattr(-,root,root,-)' in %files, as:
     %files
     %defattr(-,root,root,-)
     %doc BUGS CHANGES GPL README examples/wipefd0 examples/wswap.pl secure_del.html
     %{_bindir}/wipe
     %{_mandir}/man1/wipe.1.gz
     %{_mandir}/tr/man1/wipe.1.gz
   + consider fixing the spelling of your name in %changelog

xx - license meets Licensing Guidelines
   + license should be GPL+ since the source code / output/ accompanying
documentation does not state the version:
http://fedoraproject.org/wiki/Licensing#SoftwareLicenses

xx - License field meets actual license
   + should be GPL+ and not GPLv2

xx - upstream license file included in %doc
   + include GPL

OK - spec file uses American English
OK - spec file is legible
OK - sources match upstream sources
OK - package builds successfully
OK - ExcludeArch not needed
OK - build dependencies correctly listed

xx - no locales
   + include the localized man page (needs to be converted to UTF-8) as:
     mv wipe.tr.1 wipe.1 && \
       install -p -m644 wipe.1 $RPM_BUILD_ROOT/%{_mandir}/tr/man1/

OK - no shared libraries
OK - package is not relocatable
OK - file and directory ownership
OK - no duplicates in %file

OK - file permissions set properly
   + consider using '%defattr(-,root,root,-)' in %files, as:
     %files
     %defattr(-,root,root,-)
     %doc BUGS CHANGES GPL README examples/wipefd0 examples/wswap.pl secure_del.html
     %{_bindir}/wipe
     %{_mandir}/man1/wipe.1.gz
     %{_mandir}/tr/man1/wipe.1.gz

OK - %clean present
OK - macros used consistently
OK - contains code and permissable content
OK - -doc not needed
OK - contents of %doc does not affect the runtime
OK - no header files
OK - no static libraries
OK - no pkgconfig files
OK - no library files
OK - -devel not needed
OK - no libtool archives
OK - %{name}.desktop file not needed
OK - does not own files or directories owned by other packages
OK - buildroot correctly prepped
OK - all file names valid UTF-8

SHOULD Items:

OK - upstream provides license text
xx - no translations for description and summary
OK - package builds in mock successfully
OK - package builds on all supported architectures
OK - package functions as expected
OK - scriptlets not needed
OK - subpackages not needed
OK - no pkgconfig files
OK - no file dependencies

Here is a patch to fix most of these issues:
http://rishi.fedorapeople.org/wipe.spec.patch

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.