[Bug 426650] Review Request: linux-igd - Daemon that emulates Microsoft's Internet Connection Service

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: linux-igd - Daemon that emulates Microsoft's Internet Connection Service


https://bugzilla.redhat.com/show_bug.cgi?id=426650





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-12-24 01:43 EST -------
or general packaging guidelines, you can refer to
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

Also, you can check your rpms by rpmlint (in rpmlint rpm)
beforehands for generic packaging errors.

* Why do you want to use "linux-igd" for rpm name instead of
  using "linuxigd" used as tarball name?

* Please consider to use %?_dist tag.
  http://fedoraproject.org/wiki/Packaging/DistTag

* Sourceo must be given with full URL
  http://fedoraproject.org/wiki/Packaging/SourceURL

* For Fedora the license tag "GPL" is not valid.
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines
  http://fedoraproject.org/wiki/Licensing

* linux-igd.src: E: description-line-too-long
  This is gained from "rpmlint *.src.rpm". You can check what
  this error means by
  "rpmlint -I description-line-too-long".

* BuildRoot tag you are using does not follow Fedora policy.
  Please refer to "BuildRoot tag" of the "Guidelines" wiki.

* Your srpm does not build.
  http://koji.fedoraproject.org/koji/taskinfo?taskID=308640

* The lines
-------------------------------------------------
echo 'Installing into:'
echo $RPM_BUILD_ROOT
-------------------------------------------------
  is not needed (rpmbuild calls shell scripts with "set -x")

* linux-igd.src: E: no-cleaning-of-buildroot %install
  Please fix this also.

* Please use macros
  http://fedoraproject.org/wiki/Packaging/RPMMacros
  - For example, /etc must be %_sysconfdir
  - Please don't use /etc/rc.d, instead use %_initrddir
    (/etc/rc.d/init.d)

* To treat installation of rc service scripts, please
  refer to the section "Services" of
  http://fedoraproject.org/wiki/Packaging/ScriptletSnippets

! Note
  Please modify the release number of your spec file every time
  you modify your spec file to avoid confusion.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.