[Bug 426650] Review Request: linux-igd - Daemon that emulates Microsoft's Internet Connection Service

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: linux-igd - Daemon that emulates Microsoft's Internet Connection Service


https://bugzilla.redhat.com/show_bug.cgi?id=426650





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-12-24 10:52 EST -------
For 1.0-2:

* Redundant BuildRequires
  - BuildRequires: gcc glibc-devel are redundant
    (Fedora mimimal buildroot already contains this:
     http://koji.fedoraproject.org/scratch/mtasaka/task_309043/logs/i386/root.log )

    libupnp-devel is needed for BuildRequires.

* Fedora specific compilation flags
  - Fedora specific compilation flags are not honored.
    http://koji.fedoraproject.org/scratch/mtasaka/task_309043/logs/i386/build.log
----------------------------------------------------------------
    45  + pushd linuxigd-1.0
    46  ~/build/BUILD/linux-igd/linuxigd-1.0 ~/build/BUILD/linux-igd
    47  + make 'OPT=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i38
6 -mtune=generic -fasynchronous-unwind-tables'
    48  gcc -Wall -g -O2 -I/usr/include -I../include -c main.c
    49  gcc -Wall -g -O2 -I/usr/include -I../include -c gatedevice.c
    50  gcc -Wall -g -O2 -I/usr/include -I../include -c pmlist.c
    51  gcc -Wall -g -O2 -I/usr/include -I../include -c util.c
    52  gcc -Wall -g -O2 -I/usr/include -I../include -c config.c
    53  config.c: In function 'parseConfigFile':
    54  config.c:170: warning: implicit declaration of function 'strnlen'
    55  gcc -Wall -g -O2 main.o gatedevice.o pmlist.o util.o config.o -lpthread
-lupnp -lixml -lthreadutil -L/usr/lib -L../libs -o upnp
d
----------------------------------------------------------------
    From Makefile
    make CFLAGS="RPM_OPT_FLAGS"
    should honor Fedora specific compilation flags

* Parallel make
  - Please support parallel make if possible (please refer to the
    section "Parallel make" of
    http://fedoraproject.org/wiki/Packaging/Guidelines )

* Documents installation
  - Please use %doc macro. For example:
    http://cvs.fedoraproject.org/viewcvs/*checkout*/devel/jd/jd.spec

    %doc macro
    - First delete %RPM_BUILD_ROOT%_defaultdocdir/%name-%version then
      create it
    - Then installs the files/directories/etc listed in %doc to the
      directory
    - And automatically mark installed files as %doc

* Syntax error
----------------------------------------------------------------
linux-igd.i386: E: shell-syntax-error-in-%preun
----------------------------------------------------------------
  - The line
----------------------------------------------------------------
f [ "$1" -ge "1" ]; then
----------------------------------------------------------------
    has syntax error.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.