[Bug 426738] Review Request: pards - A library for PARallel programs with Dataflow Synchronization

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pards - A library for PARallel programs with Dataflow Synchronization


https://bugzilla.redhat.com/show_bug.cgi?id=426738


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-12-25 12:49 EST -------
_Very_ quick check (before I can sponsor you). I am just
glancing at your spec file.

- Please fix SourceURL ref:
  http://cvs.fedoraproject.org/viewcvs/*checkout*/devel/jd/jd.spec

- BuildRequires: glibc-common, binutils are redundant

- Usually -devel package should have the dependency for main
  package
  (please see the line "MUST: 
   In the vast majority of cases, devel packages must... of
   http://fedoraproject.org/wiki/Packaging/ReviewGuidelines )

- "Group" of main package perhaps needs fixing ref:
   http://cvs.fedoraproject.org/viewcvs/*checkout*/devel/libtcd/libtcd.spec

- Move char code conversion section from %build to %prep
  (for rpmbuild -bc --short-circuit)

- Use "-p" option when using "cp" or "install" commands
  ("Timestamps" section of Guildlines wiki)

- Remove static archives unless needed

- It seems that -devel package does not contain any symlinks
  against installed libraries??
  (by the way "make install ...." does not work?)

- Stripping binaries by yourself is forbidden.

! Please insert one line between
---------------------------------------------------------
%doc ChangeLog README README.ja LICENSE
%files devel
----------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.