[Bug 426828] Review Request: perl-XML-Generator-DBI - Generate SAX events from SQL queries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-XML-Generator-DBI - Generate SAX events from SQL queries


https://bugzilla.redhat.com/show_bug.cgi?id=426828


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-12-27 22:28 EST -------
Review:
+ package builds in mock (rawhide).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
fff6dad098bfa66a587066e3afb3664e  XML-Generator-DBI-1.00.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test output is
All tests successful.
Files=6, Tests=28,  6 wallclock secs ( 1.08 cusr +  0.09 csys =  1.17 CPU)

+ Package  perl-XML-Generator-DBI-1.00-3.fc9 ->
  Provides: perl(XML::Generator::DBI) = 1.00
  Requires: perl(MIME::Base64) perl(XML::SAX::Base) perl(strict) perl(vars) 

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.