[Bug 426350] Review Request: mono-basic
bugzilla at redhat.com
bugzilla at redhat.com
Fri Dec 28 18:23:32 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: mono-basic
https://bugzilla.redhat.com/show_bug.cgi?id=426350
david at lovesunix.net changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|nobody at fedoraproject.org |david at lovesunix.net
Flag| |fedora-review?
------- Additional Comments From david at lovesunix.net 2007-12-28 13:23 EST -------
I'll take this as a bribe for fixing #394851.
GOOD:
builds cleanly in mock (tested x86_64 Rawhide and i386 F8)
Owns all it's file and directories
the spec is in clean US English (and nifty sed magic)
BAD:
GPL/LGPL are no longer valid licenses
Summary needs to be capitalized (minor but rpmlint complains so let's shut it up)
mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 7)
Aside that, the spec seems to comply to packaging standards. Is there any reason to export the
language variable?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list