[Bug 251950] Review Request: moodbar - Identifies the "mood" of your music files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: moodbar - Identifies the "mood" of your music files


https://bugzilla.redhat.com/show_bug.cgi?id=251950





------- Additional Comments From debarshi.ray at gmail.com  2007-12-28 14:21 EST -------
MUST Items: 

OK - rpmlint is clean on SRPM, RPM and installed package

xx - follows Package Naming Guidelines
   + although the Debian package is named 'moodbar', PLD-Linux, OpenSUSE and
FreeBSD call it 'gstreamer-plugins-moodbar'; in fact the README says Moodbar is
the algorithm and the package contains a GStreamer plugin and an application --
what do you think?

OK - spec file is named as %{name}.spec

xx - package meets Packaging Guidelines
   + consider using %{version} in Source0 to avoid bumping it every time
   + remove the versioned BuildRequires since both F-7 and F-8 have
gstreamer-devel >= 0.10
   + consider using '%configure --disable-static' to avoid building the static
library
   + consider using 'INSTALL="%{__install} -p"' as:
     make install INSTALL="%{__install} -p" DESTDIR=$RPM_BUILD_ROOT

OK - license meets Licensing Guidelines
OK - License field meets actual license
OK - upstream license file included in %doc
OK - spec file uses American English
OK - spec file is legible
OK - sources match upstream sources
OK - package builds successfully
OK - ExcludeArch not needed
OK - build dependencies correctly listed
OK - no locales
OK - no shared libraries in any of the dynamic linker's default paths
OK - package is not relocatable
OK - file and directory ownership
OK - no duplicates in %file
OK - file permissions set properly
OK - %clean present
OK - macros used consistently
OK - contains code and permissable content
OK - -doc not needed
OK - contents of %doc does not affect the runtime
OK - no header files
OK - no static libraries
OK - no pkgconfig files
OK - no library files with a suffix
OK - -devel not needed
OK - libtool archives deleted
OK - %{name}.desktop file not needed
OK - does not own files or directories owned by other packages
OK - buildroot correctly prepped
OK - all file names valid UTF-8

SHOULD Items:

OK - upstream provides license text
xx - no translations for description and summary
OK - package builds in mock successfully
OK - package builds on all supported architectures

xx - package functions as expected
   + moodbar crashes -- Debian package has a patch to fix incorrect interaction
with GLib threading system

OK - scriptlets not needed
OK - subpackages not needed
OK - no pkgconfig files
OK - no file dependencies

Here is a patch to fix some of these issues:
http://rishi.fedorapeople.org/moodbar.spec.patch

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.