[Bug 426646] Review Request: perl-XML-Merge - Flexibly merge XML documents

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-XML-Merge - Flexibly merge XML documents


https://bugzilla.redhat.com/show_bug.cgi?id=426646


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-12-28 22:36 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
bab8d2a11865ee20b2702b0378a53339  XML-Merge-1.2.565EgGd.tgz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test output is
t/00basic....ok
t/01text.....ok
t/02keep.....ok
All tests successful.
Files=3, Tests=45,  1 wallclock secs ( 1.03 cusr +  0.05 csys =  1.08 CPU)
+ Package  perl-XML-Merge-1.2.565EgGd-2.fc9 ->
  Provides: perl(XML::Merge) = 1.2.565
  Requires: perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(XML::Tidy) perl(base)
perl(strict) perl(warnings)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.