[Bug 426919] Review Request: libpar2 - Library for performing common tasks related to PAR recovery sets

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libpar2 - Library for performing common tasks related to PAR recovery sets


https://bugzilla.redhat.com/show_bug.cgi?id=426919





------- Additional Comments From adel.gadllah at gmail.com  2007-12-29 07:22 EST -------
(In reply to comment #6)
>  [!] Rpmlint output:
>         Source RPM:empty
>         rpmlint of libpar2:
>          libpar2.x86_64: W: spurious-executable-perm
> /usr/share/doc/libpar2-0.2/ChangeLog
> -> please chmod -x (or use %attr in %files... as you prefer)
>          libpar2.x86_64: W: wrong-file-end-of-line-encoding
> /usr/share/doc/libpar2-0.2/README
>          libpar2.x86_64: W: wrong-file-end-of-line-encoding
> /usr/share/doc/libpar2-0.2/ROADMAP
>          libpar2.x86_64: W: wrong-file-end-of-line-encoding
> /usr/share/doc/libpar2-0.2/AUTHORS
> -> just cosmetic. please fix them if you feel like doing it. Since they come
> with CRLF from upstream, it's entirely up to you.

Fixed: http://tgmweb.at/gadllah/libpar2.spec


> ================
> *** APPROVED ***
> ================
> 
> If I were you I would drop the makefile patch and use
>   make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
> which has the advantage of not being dependent on upstream's Makefile.
> Up to you to decide.

OK , fixed it in the new spec too.

> Once again, sorry for forgetting to attach my spec :(

np thx for the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.