[Bug 427010] Review Request: abcmusiex - Training music score (pentagram) reading

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abcmusiex - Training music score (pentagram) reading


https://bugzilla.redhat.com/show_bug.cgi?id=427010


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tibbs at math.uh.edu




------- Additional Comments From tibbs at math.uh.edu  2007-12-30 02:27 EST -------
Blocking NEEDSPONSOR, since this is your first package.  You will need to find a
sponsor before you can obtain access to the Fedora package CVS and buildsystem.
 See http://fedoraproject.org/wiki/PackageMaintainers/Join and more specifically
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored for more
information on the sponsorship process.

Some sponsors will want to see you help out with reviews of other packages, and
some sponsors are willing to work with upstream software authors get their
packages into the distro.  For my part, I'm not really interested in the
software but if the packager of abcMIDI is willing to co-maintain this package
with you (and you fix the below packaging issues) then I'm willing to sponsor
you.  Are you in contact with him?

As for this package, it looks mostly OK, but I have a few comments and questions:

I don't understand "%(echo $HOME)/%{name}/RPMS/" in the spec; it should not be
there and in any case you should never depend on the environment of the person
building the package, which doesn't persist when building in mock and is
meaningless in the buildsystem.

BuildRoot: should be
  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

Souce0: should be the full URL to the tarball, probably something like:
  http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz

You should use %{_bindir}/abcmusiex in your %files list instead of using /usr/bin.

Even though you call the configure script properly, your makefile doesn't call
gcc with any flags.  This results in the debuginfo package being empty, among
other things.  It is my understanding that some specifics of the build note
generation also require that you call ld instead of letting the compiler link
the executable itself, although I do not understand the details.

You should package the NEWS file as %doc.  It is not necessary that you include
the entirety of the program's changelog in your %changelog, since that
represents the changelog of the package, not of the program contained within it.

The sourceforge page says that this program requires abc2prt and abcm2ps but
neither of them is provided by the dependencies of this package.  Some abc
executables are provided by the abcMIDI package but not those two.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.