[Bug 417111] Review Request: youtube-dl - Download videos from YouTube.com

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: youtube-dl - Download videos from YouTube.com


https://bugzilla.redhat.com/show_bug.cgi?id=417111





------- Additional Comments From lxtnow at gmail.com  2007-12-31 05:27 EST -------

# Need improvment :

---
install -m 755 %{SOURCE0} $RPM_BUILD_ROOT%{_bindir}
---
instead of
---
cp %{SOURCE0} $RPM_BUILD_ROOT%{_bindir}
chmod a+x $RPM_BUILD_ROOT%{_bindir}/youtube-dl
---


# You should add your documentation as SOURCE1 instead of use wget in spec file.

# You no need to add full path in %doc, its already do it by itself.
just : %doc index.html

So this can be remove as well :
---
wget http://www.arrakis.es/~rggi3/youtube-dl/index.html
mkdir -p $RPM_BUILD_ROOT%{_docdir}/%{name}-%{version}
mv index.html $RPM_BUILD_ROOT%{_docdir}/%{name}-%{version}/README.html
---

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.