[Bug 223591] Review Request: Magic - A very capable VLSI layout tool
bugzilla at redhat.com
bugzilla at redhat.com
Thu Feb 1 05:44:14 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Magic - A very capable VLSI layout tool
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223591
panemade at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778 |163779
nThis| |
------- Additional Comments From panemade at gmail.com 2007-02-01 00:44 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM.
- rpmlint is NOT silent for RPMS.
+ source match upstream.
f35f93bdb9ae3842879d52e08c6d7ace magic-7.4.33.tgz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible. License text included in package.
+ %doc is large so added -doc subpackage.
+ %doc does not affect runtime.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code Not contents.
+ no static libraries present.
+ no .pc files present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available
+ Dose owns the directories it creates.
+ no duplicates in %files.
+ icon cache scriptlets used.
+ Desktop file handled correctly.
+ file permissions are appropriate.
+ GUI app
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list