[Bug 222964] Review Request: dayplanner - A simple time management program.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dayplanner - A simple time management program.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222964


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-02-01 02:05 EST -------
Well, I must say that your spec file contains
not a few issues to fix.
Please check:
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

>From just I looked at your spec file:

A. Description entry
* Release
  - please add %{?_dist} entry unless you have a reason
    not to do so.
    http://fedoraproject.org/wiki/Packaging/DistTag
* Source0
  - please specify URL.
* BuildRequires
  - please remove redundant BuildRequires.
    "perl" is in minimum buildroot and required automatically
    by "perl-gettext", so this is not needed.
* %include_holidayparser
  - Currently I don't understand this well. If this package
    can use CPAN Date::HolidayParser module, you should
    not include perl module in this package and should
    submit CPAN module package instead.
    http://ftp.cpan.jp/authors/id/Z/ZE/ZERODOGG/

B. %build stage
   * Adding %build entry is preferred even if it is completely
    empty.

C. %install stage
   * "install -mXXX"
    - Use "install -p -mXXX" to keep timestamps.
   * Executable scripts/binaries install directory
    - By the way why do you install 
      "dayplanner dayplanner-daemon dayplanner-notifier" once
      into %{_datadir}/%{name} instead of directly
      installing into %{_bindir}?
   * Desktop file install
   - "install -m644 ./doc/%{name}.desktop"
     Please use desktop-file-install ("Desktop files" entry of
     http://fedoraproject.org/wiki/Packaging/Guidelines)

D. scriptlets
-------------------------------------------------------------
%post 
%{update_menus}

%postun
%{clean_menus}
-------------------------------------------------------------
   These macros are not defined. Check:
   http://fedoraproject.org/wiki/Extras/RPMMacros

E. file entry
   * macros
-------------------------------------------------------------
%{_iconsdir}/dayplanner*.png
%{_miconsdir}/dayplanner*.png
%{_liconsdir}/dayplanner*.png
%{_menudir}/%{name}
--------------------------------------------------------------
   These macros are also undefined.

  * subpackage
  - Would you explain why you want to split dayplanner-commander
    into different subpackage?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.