[Bug 226715] Review Request: irsim - Switch-level simulator

bugzilla at redhat.com bugzilla at redhat.com
Thu Feb 1 14:27:54 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: irsim - Switch-level simulator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226715





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-02-01 09:27 EST -------
Created an attachment (id=147103)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=147103&action=view)
irsim -2.1 spec file I created

Well:

* Source tarball includes unneeded symlink. Your
  original spec file does not remove this symlink
  on %clean stage.
* Passing cflags can be done in more easy way.
  And the manual modification against files 
  automatically created by configure should be avoided
  when possible.
* Timestamps are not kept

My spec file should hopefully fix them. Please check
it.
I will check if another issues are left to be fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list