[Bug 226295] Merge Review: php-pear

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: php-pear


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226295





------- Additional Comments From chris.stone at gmail.com  2007-02-01 11:18 EST -------
I gave a quick one minute perusal of the spec file, one thing I noticed is you
have %{buildroot} and $RPM_BUILD_ROOT mixed which is a blocker for the extras
guidelines (guess it is confusing or something).

The buildroot also needs to be fixed, fesco decided to use the one and only true
buildroot which is:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

Ive never seen BuildArchitecture tag before, I've always just seen "BuildArch",
guess thats okay though, just interesting, im not sure what the official tag is
or how rpm works, but I guess this works.

The standard license tag should just be "PHP License" or "PHP License 3.0", to
match rpmlint list of valid licenses.

Should the %configs have a (noreplace) flag??

And here is the really really important one:

pear 1.5.0 is out, and it fixes a bug I need to do a proper upgrade path for
php-pear-PHPUnit.

This is by no means an official review, just a few quick comments after looking
at the spec for one minute.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.