[Bug 225872] Merge Review: gtkhtml3

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gtkhtml3


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225872





------- Additional Comments From ville.skytta at iki.fi  2007-02-02 09:46 EST -------
The end result is more or less the same except that $RPM_OPT_FLAGS will just end
up twice in the actually used CFLAGS.  Consider this:

1) export CFLAGS="-DFOO_BAR $RPM_OPT_FLAGS"

2) ./configure
# let's assume configure added -DQUUX_BAZ to CFLAGS and thus wrote to Makefiles
CFLAGS = -DFOO_BAR <$RPM_OPT_FLAGS expanded> -DQUUX_BAZ

3) make CFLAGS="$CFLAGS $RPM_OPT_FLAGS" will expand to make CFLAGS="-DFOO_BAR
<$RPM_OPT_FLAGS expanded> <$RPM_OPT_FLAGS expanded>"

CFLAGS in Makefiles was overridden in 3) and thus -DQUUX_BAZ was lost.  And
$RPM_OPT_FLAGS ended up in CFLAGS twice.  Whatever configure adds to CFLAGS
affects what gets written to the Makefiles, not the environment, ie. step 3)
won't know about it and will trump configure's modifications.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.