[Bug 226533] Merge Review: vsftpd

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: vsftpd


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226533


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|jpmahowald at gmail.com        |mbarabas at redhat.com
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From jpmahowald at gmail.com  2007-02-03 11:33 EST -------
Good:
+ License GPL
+ Follows naming guidelines
+ URL to source
+ %clean section
+ use of %doc macro

Fix these and it's approved:
- Use %{_var}, %{_sysconfdir}, and %{_sbindir} macros for %files and %install
- Change Prereq to Requires. Also use Requires (post) and Requires (preun) style
for chkconfig and service requirements.
- use preferred BuildRoot of
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

Also drop this stuff, unneeded:
- "[ "$RPM_BUILD_ROOT" != "/" ] && " in %clean
- Requires: openssl, pam, libcap
- usermod requirement, not used (commented out).


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.