[Bug 225984] Merge Review: lftp

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: lftp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225984


ruben at rubenkerkhof.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|ruben at rubenkerkhof.com      |mbarabas at redhat.com
                 CC|                            |ruben at rubenkerkhof.com
               Flag|fedora-review?              |fedora-review-




------- Additional Comments From ruben at rubenkerkhof.com  2007-02-03 12:03 EST -------
* RPM name is OK
* Source lftp-3.5.1.tar.bz2 is the same as upstream
* Builds fine in mock
* File list looks OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* Spec file: some paths are not replaced with RPM macros
  (wiki: QAChecklist item 7)
* BuildRequires: gettext is missing (required to build the translations)
* The %makeinstall macro should not be used
  (wiki: PackagingGuidelines#MakeInstall)
* rpmlint is not silent, see below

Minor:
* Duplicate BuildRequires: autoconf (by automake), automake (by libtool)
* Please honor $RPM_OPT_FLAGS

rpmlint of lftp-3.5.1-2.fc6.i386.rpm:E: lftp binary-or-shlib-defines-rpath /usr/lib/liblftp-tasks.so.
0.0.0 ['/usr/lib']
E: lftp binary-or-shlib-defines-rpath /usr/lib/lftp/3.5.1/proto-ftp.so ['/usr/lib/lftp/3.5.1', '/usr/lib']
E: lftp binary-or-shlib-defines-rpath /usr/lib/lftp/3.5.1/proto-fish.so ['/usr/lib/lftp/3.5.1', '/usr/lib']
E: lftp binary-or-shlib-defines-rpath /usr/lib/lftp/3.5.1/proto-http.so ['/usr/lib/lftp/3.5.1', '/usr/lib']
E: lftp binary-or-shlib-defines-rpath /usr/lib/lftp/3.5.1/liblftp-network.so ['/usr/lib']
E: lftp binary-or-shlib-defines-rpath /usr/lib/lftp/3.5.1/proto-sftp.so ['/usr/lib/lftp/3.5.1', '/usr/lib']
W: lftp conffile-without-noreplace-flag /etc/lftp.conf
W: lftp devel-file-in-non-devel-package /usr/lib/liblftp-jobs.so
W: lftp devel-file-in-non-devel-package /usr/lib/liblftp-tasks.so
E: lftp library-without-ldconfig-postin /usr/lib/liblftp-jobs.so.0.0.0
E: lftp library-without-ldconfig-postun /usr/lib/liblftp-jobs.so.0.0.0
E: lftp library-without-ldconfig-postin /usr/lib/liblftp-tasks.so.0.0.0
E: lftp library-without-ldconfig-postun /usr/lib/liblftp-tasks.so.0.0.0

[ruben at odin lftp]$ rpmlint lftp-3.5.1-2.fc6.src.rpm 
W: lftp mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 1)
W: lftp patch-not-applied Patch2: lftp-3.4.1-dont_core.patch
W: lftp patch-not-applied Patch181694: lftp-3.4.2-fix-redirect-coredump.patch
W: lftp patch-not-applied Patch173276: lftp-3.3.5-bz173276.patch



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.