[Bug 225857] Merge Review: grep

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: grep


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225857


ruben at rubenkerkhof.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|ruben at rubenkerkhof.com      |skasal at redhat.com
                 CC|                            |ruben at rubenkerkhof.com
               Flag|fedora-review?              |fedora-review-




------- Additional Comments From ruben at rubenkerkhof.com  2007-02-03 12:19 EST -------
* RPM name is OK
* Source grep-2.5.1a.tar.bz2 is the same as upstream
* This is the latest version
* Builds fine in mock

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* BuildRequires: gzip should not be included
  (wiki: PackagingGuidelines#Exceptions)
* Encoding should be UTF-8
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* The %makeinstall macro should not be used
  (wiki: PackagingGuidelines#MakeInstall)
* The package should contain the text of the license
  (wiki: Packaging/ReviewGuidelines)
* Don't use PreReq for install-info, use Requires(post) and Requires(postun)
* Please don't strip symbols from files (LDFLAGS= -s)

Rpmlint is not silent:
Source RPM:
W: grep summary-ended-with-dot The GNU versions of grep pattern matching utilities.
E: grep tag-not-utf8 %changelog
E: grep non-utf8-spec-file grep.spec
W: grep prereq-use /sbin/install-info
W: grep make-check-outside-check-section make check
W: grep macro-in-%changelog post

rpmlint of grep:
W: grep summary-ended-with-dot The GNU versions of grep pattern matching utilities.
E: grep tag-not-utf8 %changelog


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.