[Bug 225720] Merge Review: eject

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: eject


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225720


ruben at rubenkerkhof.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|ruben at rubenkerkhof.com      |than at redhat.com
                 CC|                            |ruben at rubenkerkhof.com
               Flag|fedora-review?              |fedora-review-




------- Additional Comments From ruben at rubenkerkhof.com  2007-02-03 13:24 EST -------
* RPM name is OK
* Source eject-2.1.5.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* File list looks OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)

Minor:
* Duplicate BuildRequires: autoconf (by automake), automake (by libtool)

Notes:
* Please use {?dist} in Release tag


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.