[Bug 225735] Merge Review: ethtool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: ethtool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225735


ruben at rubenkerkhof.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|ruben at rubenkerkhof.com      |jgarzik at redhat.com
                 CC|                            |ruben at rubenkerkhof.com
               Flag|fedora-review?              |fedora-review-




------- Additional Comments From ruben at rubenkerkhof.com  2007-02-03 13:32 EST -------
* RPM name is OK
* Source ethtool-5.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* File list looks OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* Spec file: some paths are not replaced with RPM macros
  (wiki: QAChecklist item 7)
* The %makeinstall macro should not be used
  (wiki: PackagingGuidelines#MakeInstall)

Rpmlint is not clean:

[ruben at odin ethtool]$ rpmlint -i ethtool-5-1.fc6.i386.rpm 
W: ethtool symlink-should-be-relative /usr/sbin/ethtool /sbin/ethtool
Absolute symlinks are problematic eg. when working with chroot environments.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.