[Bug 225777] Merge Review: gawk

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gawk


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225777


dan at danny.cz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|dan at danny.cz                |kzak at redhat.com
                 CC|                            |dan at danny.cz
               Flag|fedora-review?              |fedora-review-




------- Additional Comments From dan at danny.cz  2007-02-03 14:09 EST -------
Here is the summary and formal review:

OK	source files match upstream:
	  5703f72d0eea1d463f735aad8222655f  gawk-3.1.5.tar.bz2
	  5e260a21e93a29ff9066c39850ece860  gawk-3.1.5-ps.tar.gz
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	license field matches the actual license.
OK	license is open source-compatible. License text included in package.
OK	latest version is being packaged.
OK	BuildRequires are proper.
OK	compiler flags are appropriate.
OK	%clean is present.
OK	package builds in mock (i386).
OK	package installs properly
OK	debuginfo package looks complete.
OK	final provides and requires looks sane
OK	no shared libraries are added to the regular linker search paths.
OK	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	code, not content.
OK	%docs are not necessary for the proper functioning of the package.
OK	no headers.
OK	no pkgconfig files.
OK	no libtool .la droppings.
OK	not a GUI app.

MUST FIX:

BAD build root is NOT correct.
      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

BAD	rpmlint is NOT silent, problems are in the spec file only
W: gawk summary-ended-with-dot The GNU version of the awk text processing utility.
W: gawk no-url-tag
W: gawk make-check-outside-check-section make check
W: gawk mixed-use-of-spaces-and-tabs (spaces: line 86, tab: line 21)

The URL is http://www.gnu.org/software/gawk/gawk.html

BAD	%check is NOT present, but "make check" target exists and is used
BAD	scriptlets present, but not sane (bug #223686).
BAD	documentation is NOT small, so -docs subpackage may be necessary.
BAD	parallel make not used


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.