[Bug 225710] Merge Review: dtach

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: dtach


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225710


jspaleta at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|jspaleta at gmail.com          |nobody at fedoraproject.org
               Flag|fedora-review?              |fedora-review-




------- Additional Comments From jspaleta at gmail.com  2007-02-03 14:48 EST -------
Summary:
Minor specfile work need. See attached specfile diff.
Note that I had to run the specfile through iconv to quiet the utf-8 related
rpmlint warnings. The owner will need to implement the suggested changes, or
come back into the ticket for discussion the suggestions they feel are misguided.

dtach
GOOD
+ rpmlint... see the notes at the end. I've rolled in changes into the spec from
the rpmlint log info
+ packagename is fine
+ specfile name is fine
+ license check 
+  GPL , matches source license, and COPYING file included in %doc
+ spec is english-ish
+ md5sum check of sources
9aa11433d5a5b4b9fed271f10102cf6f  dtach-0.7.tar.gz from source tag
9aa11433d5a5b4b9fed271f10102cf6f  ../rpmbuild/SOURCES/dtach-0.7.tar.gz  from
srpm install
+ mock build  as done by matt
http://linux.dell.com/files/fedora/FixBuildRequires/mock-results-core/i386/dtach-0.7-1.2.2.src.rpm/result
+ no buildrequires....
+ no shared libs
+ not designed to be relocatable
+ no duplicates in the files section
+ file permissions look okay to me
+ no headers or static libs
+ docs section looks fine
+ no devel subpackage
+ no gui apps
+ no obvious duplicate file/directory ownership

BAD
There is nothing I consider a significant blocker. 
There are some minor specfile changes which are in the diff
so I'm failing this review on general principles until the
spec diff gets reviewed by the owner and incorporated.

I did have to run the spec file through iconv to quiet the rpmlint utf-8 warnings.

 
why does this spec have:
rm -rf $RPM_BUILD_DIR/%{name}-%{version}  ?
I don't think that is necessary so I have removed it in my new spec diff

rpmlint run from matt/dell:
rpmlint on ./dtach-0.7-1.2.2.src.rpm
W: dtach summary-ended-with-dot A simple program that emulates the detach
feature of screen.
... fixed in the spec diff
E: dtach tag-not-utf8 %changelog
... wtf?
E: dtach non-utf8-spec-file dtach.spec
... wtf?
W: dtach setup-not-quiet
... fixed in spec diff
W: dtach macro-in-%changelog clean
... fixed in spec diff... just to be sure this isnt gonna be a problem. Its
silly really.

rpmlint on ./dtach-debuginfo-0.7-1.2.2.i386.rpm
E: dtach-debuginfo tag-not-utf8 %changelog
rpmlint on ./dtach-0.7-1.2.2.i386.rpm
W: dtach summary-ended-with-dot A simple program that emulates the detach
feature of screen.
E: dtach tag-not-utf8 %changelog



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.