[Bug 225742] Merge Review: expat

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: expat


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225742


ruben at rubenkerkhof.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|ruben at rubenkerkhof.com      |jorton at redhat.com
                 CC|                            |ruben at rubenkerkhof.com
               Flag|fedora-review?              |fedora-review-




------- Additional Comments From ruben at rubenkerkhof.com  2007-02-03 15:03 EST -------
* RPM name is OK
* Source expat-1.95.8.tar.gz is the same as upstream
* Builds fine in mock
* File list of expat looks OK
* File list of expat-devel looks OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* The %makeinstall macro should not be used
  (wiki: PackagingGuidelines#MakeInstall)
* rpmlint of expat: W: expat summary-ended-with-dot A library for parsing XML.
* rpmlint of expat-devel: W: expat-devel summary-ended-with-dot Libraries and include files to 
develop XML applications with expat.

Minor:
* Duplicate BuildRequires: autoconf (by automake), automake (by libtool)

Notes:
* Please use {?dist} in Release tag
* You should Require(post) and Require(postun) ldconfig
* Is it necessary to include static binaries (see the wiki: PackageGuidelines/Exclusion of Static Libraries


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.