[Bug 226133] Merge Review: mc

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: mc


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226133





------- Additional Comments From dan at danny.cz  2007-02-03 15:36 EST -------
first shots:
- package release tag - because your are using CVS snapshot, so you must comply
with
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-cfd71146dbb6f00cec9fe3623ea619f843394837
- perhaps wrong usage of %{makeinstall} - details at
http://fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002
- unowned dir - %{_libexecdir}/mc
- mixed usage of spaces and tabs in the spec file, old entries in the changelog
don't have escaped '%' in macros
- explicit setting of --foodir=%{_foodir} when running the %configure macro, it
is its function to set them :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.