[Bug 226380] Merge Review: rsync

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: rsync


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226380


ed at eh3.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |fenlason at redhat.com
                 CC|                            |ed at eh3.com
               Flag|                            |fedora-review-




------- Additional Comments From ed at eh3.com  2007-02-03 16:13 EST -------

Hi there, here's a quick review:

good:
 + source matches upstream
 + license is OK and correctly listed
 + spec looks clean/read-able

needswork:
 - please remove the trailing '.' from Summary

 - please add "URL: http://rsync.samba.org/"

 - please change the Source: URL so it works with "spectool -g" 
   such as:
   Source: http://rsync.samba.org/ftp/rsync/rsync-%{version}.tar.gz

 - please consider adding %{?dist} to Release

 - please delete the Prefix: entry

 - please use the preferred BuildRoot:
   %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

 - rpmlint reports a few additional warnings (mostly repeats of above):
http://linux.dell.com/files/fedora/FixBuildRequires/mock-results-core/i386/rsync-2.6.9-1.src.rpm/result/rpmlint.log


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.