[Bug 226105] Merge Review: logwatch

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: logwatch


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226105


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|kevin at tummy.com             |varekova at redhat.com
               Flag|fedora-review?              |fedora-review-




------- Additional Comments From kevin at tummy.com  2007-02-03 18:19 EST -------

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
See below - Sources match upstream md5sum:
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
See below - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have subpackages require base package with fully versioned depend.
OK - Should have dist tag
See below - Should package latest version
5 open bugs - check for outstanding bugs on package.

Issues:

1. Should use a full URL in Source line.
What is the upstream for this package?

This is version 3.7.4, which I see no where on
http://www2.logwatch.org:81/tabs/download/
That site has version 7.3.2.

2. Should include COPYING file.

3. Buildroot should be standard buildroot.

4. rpmlint, out little pal says:

rpmlint on ./logrotate-debuginfo-3.7.4-11.fc7.i386.rpm
W: logrotate-debuginfo no-url-tag
rpmlint on ./logrotate-3.7.4-11.fc7.src.rpm
W: logrotate no-url-tag
rpmlint on ./logrotate-3.7.4-11.fc7.i386.rpm
W: logrotate no-url-tag

URL should be fixed. See point 1.

E: logrotate zero-length /var/lib/logrotate.status

Should this be set the same way.

5. Should look at the 5 open bugs pending.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.