[Bug 226542] Merge Review: words

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: words


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226542


roozbeh at farsiweb.info changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|roozbeh at farsiweb.info       |kzak at redhat.com
               Flag|fedora-review?              |fedora-review-




------- Additional Comments From roozbeh at farsiweb.info  2007-02-03 21:00 EST -------
Partial review:

GOOD
====
MUST: source matches upstream (md5sum checked)

BAD
===
MUST: rpmlint output
  SRPM:
  W: words summary-ended-with-dot A dictionary of English words for the
/usr/share/dict directory.
  E: words tag-not-utf8 %changelog
  W: words invalid-license public domain
  E: words non-utf8-spec-file words.spec
  E: words no-cleaning-of-buildroot %install

  All should be fixed:
    - Change License to "Public Domain"
    - Remove dot at the end of summart
    - change SPEC file to UTF-8
    - clean the buildroot in %install using rm -rf $RPM_BUILD_ROOT
  
  For the RPM, the errors are a subset of above.

  * Version field is quite arbitrary (3.0) instead of matching upstream.

  * Separate license file into a different "Source" file. Also explain in the
    file that the license info in the file readme.txt is deprecated.

  * Change /usr/share in %files section to %{_datadir}
  
  * Change %defattr(-,root,root) to %defattr(-,root,root,-)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.