[Bug 225918] Merge Review: iso-codes
bugzilla at redhat.com
bugzilla at redhat.com
Sun Feb 4 02:39:43 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: iso-codes
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225918
roozbeh at farsiweb.info changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|nobody at fedoraproject.org |dsantani at redhat.com
CC| |roozbeh at farsiweb.info
Flag| |fedora-review-
------- Additional Comments From roozbeh at farsiweb.info 2007-02-03 21:39 EST -------
Partial review:
MUSTFIX:
* %{_datadir}/locale/*/LC_MESSAGES/*.mo is used instead of find_lang. See:
http://fedoraproject.org/wiki/Packaging/Guidelines#locales
* Add dependency on pkgconfig to -devel package.
* Don't use %makeinstall. See:
http://fedoraproject.org/wiki/Packaging/Guidelines#MakeInstall
* Either own /usr/share/xml, or depend on xml-common.
* The ISO standards named in description should be changed to their proper name,
"ISO 639" (instead of "ISO-639"), "ISO 3166-1" (instead of "ISO-3166"), and "ISO
3166-2" (instead of "ISO-3166-2").
SUGGESTIONS:
* Consider using new upstream version (1.0a is available from:
http://ftp.debian.org/debian/pool/main/i/iso-codes/)
* No need to use %{__mv} and %{__rm}. Use normal mv and rm.
* Use "make %{?_smp_mflags}"
* Add a dot at the end of -devel's description.
* Could do
%{_datadir}/iso-codes
Instead of:
%dir %{_datadir}/iso-codes
%{_datadir}/iso-codes/*.tab
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list