[Bug 225618] Merge Review: bitstream-vera-fonts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: bitstream-vera-fonts


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225618


roozbeh at farsiweb.info changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |besfahbo at redhat.com
               Flag|                            |fedora-review-




------- Additional Comments From roozbeh at farsiweb.info  2007-02-03 21:58 EST -------
Generlly fine. Partial review:
* Consider using %{?dist} in Release (mostly useful for upgrades, as different
distro versions tend to need to have different scriptlets always).

* rpmlint output:

E: bitstream-vera-fonts description-line-too-long the licensing FAQ in
/usr/share/doc/bitstream-vera-fonts-1.10/COPYRIGHT.TXT or the
W: bitstream-vera-fonts invalid-license Redistributable, with restrictions

  Both should be fixed.

* Use "-p" option to install in %install

* This:
    %dir %{fontdir}
    %{fontdir}/*.ttf
  could be replaced with this:
    %{fontdir}

* Uses /usr/share/fonts without owning it or depending on a package that does
(fontconfig).


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.