[Bug 225984] Merge Review: lftp

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: lftp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225984





------- Additional Comments From ruben at rubenkerkhof.com  2007-02-04 05:11 EST -------
Ah, you're right, my mistake.
That leaves us with:

* RPM name is OK
* Source lftp-3.5.9.tar.bz2 is the same as upstream
* This is the latest version
* Builds fine in mock
* File list looks OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* Spec file: some paths are not replaced with RPM macros
  (wiki: QAChecklist item 7)
* BuildRequires: gettext is missing (required to build the translations)
* The %makeinstall macro should not be used
  (wiki: PackagingGuidelines#MakeInstall)
* Preserve timestamps when installing files
  (wiki: PackagingGuidelines#Timestamps

Minor:
* Duplicate BuildRequires: autoconf (by automake), automake (by libtool)

Rpmlint output:

Source RPM:
W: lftp mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 1)

rpmlint of lftp:
W: lftp incoherent-version-in-changelog 3.5.9 3.5.9-1.fc6
E: lftp binary-or-shlib-defines-rpath /usr/lib/lftp/3.5.9/proto-ftp.so ['/usr/lib/lftp/3.5.9', '/usr/lib']
E: lftp binary-or-shlib-defines-rpath /usr/lib/lftp/3.5.9/proto-fish.so ['/usr/lib/lftp/3.5.9', '/usr/lib']
E: lftp binary-or-shlib-defines-rpath /usr/lib/lftp/3.5.9/proto-http.so ['/usr/lib/lftp/3.5.9', '/usr/lib']
E: lftp binary-or-shlib-defines-rpath /usr/lib/lftp/3.5.9/liblftp-network.so ['/usr/lib']
E: lftp binary-or-shlib-defines-rpath /usr/lib/lftp/3.5.9/proto-sftp.so ['/usr/lib/lftp/3.5.9', '/usr/lib']
W: lftp conffile-without-noreplace-flag /etc/lftp.conf
W: lftp devel-file-in-non-devel-package /usr/lib/liblftp-jobs.so
W: lftp devel-file-in-non-devel-package /usr/lib/liblftp-tasks.so
E: lftp library-without-ldconfig-postin /usr/lib/liblftp-jobs.so.0.0.0
E: lftp library-without-ldconfig-postun /usr/lib/liblftp-jobs.so.0.0.0
E: lftp library-without-ldconfig-postin /usr/lib/liblftp-tasks.so.0.0.0
E: lftp library-without-ldconfig-postun /usr/lib/liblftp-tasks.so.0.0.0



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.