[Bug 226669] Merge Review: zip

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: zip


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226669


ruben at rubenkerkhof.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|ruben at rubenkerkhof.com      |varekova at redhat.com
                 CC|                            |ruben at rubenkerkhof.com
               Flag|fedora-review?              |fedora-review-




------- Additional Comments From ruben at rubenkerkhof.com  2007-02-04 06:38 EST -------
Review for release 1.2.2:
* RPM name is OK
* Source zip231.tar.gz is the same as upstream
* Source zcrypt29.tar.gz is the same as upstream
* Builds fine in mock
* File list looks OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* Encoding should be UTF-8
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* Spec file: some paths are not replaced with RPM macros
  (wiki: QAChecklist item 7)

Minor:
* The latest version is 2.32

Notes:
* Please use {?dist} in the Release tag. See http://fedoraproject.org/wiki/DistTag for more info


Rpmlint is not silent:

Source RPM:
W: zip summary-ended-with-dot A file compression and packaging utility compatible with PKZIP.
E: zip tag-not-utf8 %changelog
W: zip invalid-license distributable
E: zip non-utf8-spec-file zip.spec
W: zip mixed-use-of-spaces-and-tabs (spaces: line 51, tab: line 47)

rpmlint of zip:
W: zip summary-ended-with-dot A file compression and packaging utility compatible with PKZIP.
E: zip tag-not-utf8 %changelog
W: zip invalid-license distributable


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.