[Bug 225678] Merge Review: dcraw

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: dcraw


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225678





------- Additional Comments From dan at danny.cz  2007-02-04 07:13 EST -------
OK	source files match upstream:
		63f7859e44f914e703ccc7b9e4f9fdd8809add1850365f6186aa6df6deabc2c0 
dcraw-8.53.tar.gz
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	build root is correct.
OK	license field matches the actual license.
OK	license is open source-compatible.  License text not included upstream.
OK	latest version is being packaged.
OK	BuildRequires are proper.
OK	compiler flags are appropriate.
OK	%clean is present.
OK	package builds in mock (i386).
OK	package installs properly
OK	debuginfo package looks complete.
OK	final provides and requires are sane
OK	no shared libraries are added to the regular linker search paths.
OK	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	no scriptlets present.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	no headers.
OK	no pkgconfig files.
OK	no libtool .la droppings.
OK	not a GUI app.

MUST FIX:

BAD	rpmlint is NOT silent.
	W: dcraw summary-ended-with-dot A tool for decoding raw image data from digital
cameras.

BAD	%find_lang macro is not used for the locale files

both are rather minors and a patch for the spec file is attached

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.